[Lldb-commits] [lldb] 5c065f0 - [lldb][Windows] Fix build with MSVC compiler broken by (#108072)

[Muhammad Omair Javaid via lldb-commits]

Author: Muhammad Omair Javaid
Date: 2025-02-03T15:17:08+05:00
New Revision: 5c065f01cee5dfca28d703983d0ebefa65128e09

URL: https://github.com/llvm/llvm-project/commit/5c065f01cee5dfca28d703983d0ebefa65128e09
DIFF: https://github.com/llvm/llvm-project/commit/5c065f01cee5dfca28d703983d0ebefa65128e09.diff

LOG: [lldb][Windows] Fix build with MSVC compiler broken by (#108072)

This patch fixes LLDB Windows build with MSVC compiler. MSVC deletes
the default constructor due to virtual inheritance rules. Explicitly
define the default constructor in NativeRegisterContextWindows to
ensure constructibility.

Added: 
    

Modified: 
    lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.h

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.h b/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.h
index 0f9e37dbd9f527..2b71f639d562e9 100644
--- a/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.h
+++ b/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.h
@@ -24,6 +24,10 @@ class NativeRegisterContextWindows
   CreateHostNativeRegisterContextWindows(const ArchSpec &target_arch,
                                          NativeThreadProtocol &native_thread);
 
+  // MSVC compiler deletes the default constructor due to virtual inheritance.
+  // Explicitly defining it ensures the class remains constructible.
+  NativeRegisterContextWindows() {}
+
 protected:
   lldb::thread_t GetThreadHandle() const;
 };