[Lldb-commits] [lldb] LLDB: WatchAddress ignores modify option (PR #124847)

[Ben Jackson via lldb-commits]

puremourning wrote:

> Seeing as you are working on watchpoints here, I found that `void WatchpointList::RemoveAll(bool notify)` is sending the wrong event of `Target::eBroadcastBitBreakpointChanged` instead of sending `Target::eBroadcastBitWatchpointChanged`. Might be a good fix to get in to ensure watchpoints are solid.

Seems simple enough to change it. Though I worry about bug-compatibility, in case someone has code expecting the "wrong" event.

Let me change it quickly and see what breaks in the tests.... If you're confident it is the "right" thing to do I can push another PR.


https://github.com/llvm/llvm-project/pull/124847