[Lldb-commits] [lldb] [NFC][lldb] Document a few ivars on the value object system. (PR #124971)

via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 30 14:29:37 PST 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff bda19768de03a0322c4094c8d0e00ad033268309 87eca7770ba2a747db1843a8abfdceaa2f4debf8 --extensions cpp,h -- lldb/include/lldb/Core/Value.h lldb/include/lldb/Expression/ExpressionVariable.h lldb/include/lldb/ValueObject/ValueObjectConstResultImpl.h lldb/source/Expression/Materializer.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/include/lldb/Core/Value.h b/lldb/include/lldb/Core/Value.h
index 3714621b46..b1044eef5b 100644
--- a/lldb/include/lldb/Core/Value.h
+++ b/lldb/include/lldb/Core/Value.h
@@ -170,8 +170,8 @@ protected:
   // - Rename GetScalar() to something more indicative to what the scalar is,
   //   like GetScalarOrAddress() for example.
   // - Split GetScalar() into two functions, GetScalar() and GetAddress(), which
-  //   verify (or assert) what m_value_type is to make sure users of the class are
-  //   querying the right thing.
+  //   verify (or assert) what m_value_type is to make sure users of the class
+  //   are querying the right thing.
   // TODO: It's confusing to point to multiple possible buffers when the
   // ValueType is a host address. Value should probably always own its buffer.
   // Perhaps as a shared pointer with a copy on write system if the same buffer

``````````

</details>


https://github.com/llvm/llvm-project/pull/124971


More information about the lldb-commits mailing list