[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

[David Spickett via lldb-commits]

DavidSpickett wrote:

The easy one to fix is:
```
Traceback (most recent call last):

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\functionalities\reverse-execution\TestReverseContinueNotSupported.py", line 25, in test_reverse_continue_not_supported

    self.assertFailure(

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\packages\Python\lldbsuite\test\lldbtest.py", line 2589, in assertFailure

    self.assertEqual(error, error_str, msg)

AssertionError: 'error: windows does not support reverse execution of processes' != 'error: gdb-remote does not support reverse execution of processes'

- error: windows does not support reverse execution of processes

?        ^^^  ^^

+ error: gdb-remote does not support reverse execution of processes

?        ^ +++++ ^^
```
The odd one is:
```
ERROR: test_continue_preserves_direction (TestReverseContinueBreakpoints.TestReverseContinueBreakpoints.test_continue_preserves_direction)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\functionalities\reverse-execution\TestReverseContinueBreakpoints.py", line 95, in test_continue_preserves_direction

    self.continue_preserves_direction_internal(async_mode=False)

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\functionalities\reverse-execution\TestReverseContinueBreakpoints.py", line 102, in continue_preserves_direction_internal

    target, process, initial_threads = self.setup_recording(async_mode)

                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\functionalities\reverse-execution\TestReverseContinueBreakpoints.py", line 140, in setup_recording

    self.assertEqual(len(initial_threads), 1)

                     ^^^^^^^^^^^^^^^^^^^^

TypeError: object of type 'NoneType' has no len()
```
I will revert this and reproduce it tomorrow.

https://github.com/llvm/llvm-project/pull/123945