[Lldb-commits] [lldb] [lldb] Add support for gdb-style 'x' packet (PR #124733)

[David Spickett via lldb-commits]

================
@@ -218,7 +218,12 @@ class GDBRemoteCommunicationClient : public GDBRemoteClientBase {
 
   bool GetpPacketSupported(lldb::tid_t tid);
 
-  bool GetxPacketSupported();
+  enum class xPacketState {
+    Unimplemented,
+    Prefixed, // Successful responses start with a 'b' character.
+    Bare,     // No prefix, packets starts with the memory being read.
----------------
DavidSpickett wrote:

I would add something to these to indicate which is/was gdb/lldb's style of packet.

https://github.com/llvm/llvm-project/pull/124733