[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

[Jonas Devlieghere via lldb-commits]

================
@@ -44,12 +44,16 @@ class ProgressEventData : public EventData {
   uint64_t GetCompleted() const { return m_completed; }
   uint64_t GetTotal() const { return m_total; }
   std::string GetMessage() const {
-    std::string message = m_title;
-    if (!m_details.empty()) {
-      message.append(": ");
-      message.append(m_details);
-    }
-    return message;
+    // Only put the title in the message of the progress create event.
+    if (m_completed == 0) {
+      std::string message = m_title;
+      if (!m_details.empty()) {
+        message.append(": ");
+        message.append(m_details);
+      }
+      return message;
+    } else
+      return !m_details.empty() ? m_details : std::string();
----------------
JDevlieghere wrote:

Agreed, that method was added exactly for that reason: so we didn't need to keep adding overloads to `GetProgressFromEvent` every time we added a new field. FWIW I personally think it's reasonable to construct the string in `lldb-dap`.

https://github.com/llvm/llvm-project/pull/124648