[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)
Greg Clayton via lldb-commits
lldb-commits at lists.llvm.org
Mon Jan 27 15:58:38 PST 2025
================
@@ -44,12 +44,16 @@ class ProgressEventData : public EventData {
uint64_t GetCompleted() const { return m_completed; }
uint64_t GetTotal() const { return m_total; }
std::string GetMessage() const {
- std::string message = m_title;
- if (!m_details.empty()) {
- message.append(": ");
- message.append(m_details);
- }
- return message;
+ // Only put the title in the message of the progress create event.
+ if (m_completed == 0) {
+ std::string message = m_title;
+ if (!m_details.empty()) {
+ message.append(": ");
+ message.append(m_details);
+ }
+ return message;
+ } else
+ return !m_details.empty() ? m_details : std::string();
----------------
clayborg wrote:
Might be good to allow `title` and `detail` to be NULL and not filled in if they are NULL.
https://github.com/llvm/llvm-project/pull/124648
More information about the lldb-commits
mailing list