[Lldb-commits] [lldb] [lldb] Include api-level.h header for Android (PR #124383)

via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 27 07:29:13 PST 2025


================
@@ -29,6 +29,10 @@
 #include <sys/utsname.h>
 #include <unistd.h>
 
+#ifdef __ANDROID__
+#include <android/api-level.h>
----------------
enh-google wrote:

> is it possible those includes were necessary 10 years ago?

yeah, one reason i'm so confidently asserting that you shouldn't need this now is because i know we had a big cleanup to ensure that we hadn't missed any :-)

> we could assume that any header which includes the definition of a C function we're about to call, also includes the definition of that macro -- which I guess must be true as otherwise it wouldn't be able to annotate the declaration

correct.

https://github.com/llvm/llvm-project/pull/124383


More information about the lldb-commits mailing list