[Lldb-commits] [lldb] [lldb] Remove support and workarounds for Android 4 and older (PR #124047)
Brad Smith via lldb-commits
lldb-commits at lists.llvm.org
Thu Jan 23 11:42:30 PST 2025
================
@@ -25,13 +25,10 @@
#include <sstream>
#ifdef __ANDROID__
----------------
brad0 wrote:
> (getgrgid() has been around forever, though, so if anyone cared they could reduce the scope of this. but probably just `#if defined(__ANDROID__) && (__ANDROID_API__ >= 24)` is clearer, and groups aren't particularly meaningful on android anyway, so probably no-one cares in the meantime?)
I guess I was wondering if with another diff it would make sense to check the Android API or a comment making it clear when it would make sense to remove. Either way..
https://github.com/llvm/llvm-project/pull/124047
More information about the lldb-commits
mailing list