[Lldb-commits] [lldb] d050083 - [lldb] Avoid repeated map lookups (NFC) (#124077)

via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 23 08:46:02 PST 2025


Author: Kazu Hirata
Date: 2025-01-23T08:45:59-08:00
New Revision: d05008363d4ed87b1350701831032ea5070d5b98

URL: https://github.com/llvm/llvm-project/commit/d05008363d4ed87b1350701831032ea5070d5b98
DIFF: https://github.com/llvm/llvm-project/commit/d05008363d4ed87b1350701831032ea5070d5b98.diff

LOG: [lldb] Avoid repeated map lookups (NFC) (#124077)

Added: 
    

Modified: 
    lldb/source/Target/DynamicRegisterInfo.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Target/DynamicRegisterInfo.cpp b/lldb/source/Target/DynamicRegisterInfo.cpp
index 1a817449fa9589..9ad98a41c688c8 100644
--- a/lldb/source/Target/DynamicRegisterInfo.cpp
+++ b/lldb/source/Target/DynamicRegisterInfo.cpp
@@ -460,8 +460,8 @@ void DynamicRegisterInfo::Finalize(const ArchSpec &arch) {
   // Now update all value_regs with each register info as needed
   const size_t num_regs = m_regs.size();
   for (size_t i = 0; i < num_regs; ++i) {
-    if (m_value_regs_map.find(i) != m_value_regs_map.end())
-      m_regs[i].value_regs = m_value_regs_map[i].data();
+    if (auto it = m_value_regs_map.find(i); it != m_value_regs_map.end())
+      m_regs[i].value_regs = it->second.data();
     else
       m_regs[i].value_regs = nullptr;
   }
@@ -509,8 +509,9 @@ void DynamicRegisterInfo::Finalize(const ArchSpec &arch) {
 
   // Now update all invalidate_regs with each register info as needed
   for (size_t i = 0; i < num_regs; ++i) {
-    if (m_invalidate_regs_map.find(i) != m_invalidate_regs_map.end())
-      m_regs[i].invalidate_regs = m_invalidate_regs_map[i].data();
+    if (auto it = m_invalidate_regs_map.find(i);
+        it != m_invalidate_regs_map.end())
+      m_regs[i].invalidate_regs = it->second.data();
     else
       m_regs[i].invalidate_regs = nullptr;
   }


        


More information about the lldb-commits mailing list