[Lldb-commits] [lldb] Reland "[lldb] Implement basic support for reverse-continue" (#123906)" (PR #123945)

[David Spickett via lldb-commits]

DavidSpickett wrote:

> can you add @skipIfRemote to the tests?

Done

> Another, simpler way to fix the memory read problem might be to just tolerate failed memory writes --- log and continue.

Log and continue is liable to be "triager forgets to look at logs, wastes days, disables the test and forgets". I think we're pretty safe to improve the error messages and raise them as soon as possible here.

If we get a pile of reports about spurious failures then sure, let's log it, but stick to erroring as long as we can.

I have improved the error messages for both memory and registers.

https://github.com/llvm/llvm-project/pull/123945