[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

Walter Erquinigo via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 22 13:14:58 PST 2025


================
@@ -111,8 +111,10 @@ Error RunInTerminalLauncherCommChannel::WaitUntilDebugAdaptorAttaches(
     return message.takeError();
 }
 
-Error RunInTerminalLauncherCommChannel::NotifyPid() {
-  return m_io.SendJSON(RunInTerminalMessagePid(getpid()).ToJSON());
+Error RunInTerminalLauncherCommChannel::NotifyPid(lldb::pid_t pid) {
+  if (pid == 0)
+    pid = getpid();
----------------
walter-erquinigo wrote:

can you explain here why you added this?

https://github.com/llvm/llvm-project/pull/121269


More information about the lldb-commits mailing list