[Lldb-commits] [lldb] [LLDB][LLDB-DAP] Wire up DAP to listen to external progress events (PR #123826)
Jacob Lalonde via lldb-commits
lldb-commits at lists.llvm.org
Tue Jan 21 13:59:31 PST 2025
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/123826
>From 1e14270bbbce2531d51c7153e26d49c2bb868684 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde <jalalonde at fb.com>
Date: Tue, 21 Jan 2025 13:40:23 -0800
Subject: [PATCH] Wire up DAP to listen to external progress events, and list
the enumeration in SBDebugger
---
lldb/include/lldb/API/SBDebugger.h | 12 ++++++------
lldb/tools/lldb-dap/lldb-dap.cpp | 3 ++-
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/lldb/include/lldb/API/SBDebugger.h b/lldb/include/lldb/API/SBDebugger.h
index eb371e33c4951c..212e817e3cba5b 100644
--- a/lldb/include/lldb/API/SBDebugger.h
+++ b/lldb/include/lldb/API/SBDebugger.h
@@ -42,12 +42,12 @@ class LLDB_API SBInputReader {
class LLDB_API SBDebugger {
public:
- FLAGS_ANONYMOUS_ENUM(){
- eBroadcastBitProgress = lldb::DebuggerBroadcastBit::eBroadcastBitProgress,
- eBroadcastBitWarning = lldb::DebuggerBroadcastBit::eBroadcastBitWarning,
- eBroadcastBitError = lldb::DebuggerBroadcastBit::eBroadcastBitError,
- eBroadcastBitProgressCategory =
- lldb::DebuggerBroadcastBit::eBroadcastBitProgressCategory,
+ FLAGS_ANONYMOUS_ENUM() {
+ eBroadcastBitProgress = lldb::DebuggerBroadcastBit::eBroadcastBitProgress,
+ eBroadcastBitWarning = lldb::DebuggerBroadcastBit::eBroadcastBitWarning,
+ eBroadcastBitError = lldb::DebuggerBroadcastBit::eBroadcastBitError,
+ eBroadcastBitExternalProgress =
+ lldb::DebuggerBroadcastBit::eBroadcastBitExternalProgress,
};
SBDebugger();
diff --git a/lldb/tools/lldb-dap/lldb-dap.cpp b/lldb/tools/lldb-dap/lldb-dap.cpp
index 7e8f7b5f6df679..6b12569d90a831 100644
--- a/lldb/tools/lldb-dap/lldb-dap.cpp
+++ b/lldb/tools/lldb-dap/lldb-dap.cpp
@@ -414,7 +414,8 @@ void SendStdOutStdErr(DAP &dap, lldb::SBProcess &process) {
void ProgressEventThreadFunction(DAP &dap) {
lldb::SBListener listener("lldb-dap.progress.listener");
dap.debugger.GetBroadcaster().AddListener(
- listener, lldb::SBDebugger::eBroadcastBitProgress);
+ listener, lldb::SBDebugger::eBroadcastBitProgress |
+ lldb::SBDebugger::eBroadcastBitExternalProgress);
dap.broadcaster.AddListener(listener, eBroadcastBitStopProgressThread);
lldb::SBEvent event;
bool done = false;
More information about the lldb-commits
mailing list