[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

[Michael Buch via lldb-commits]

Michael137 wrote:

Hmm there's a clang-tidy test failing because this codepath gets hit for `UserDefinedLiteral`, which is a `CallExpr` with a single argument:
```
(lldb) p E->dump()
UserDefinedLiteral 0x15402b738 'unsigned long long'
|-ImplicitCastExpr 0x15402b720 'unsigned long long (*)(unsigned long long)' <FunctionToPointerDecay>
| `-DeclRefExpr 0x15402b6c8 'unsigned long long (unsigned long long)' lvalue Function 0x154010278 'operator""_ull' 'unsigned long long (unsigned long long)'
`-IntegerLiteral 0x15402b6a8 'unsigned long long' 1
(lldb) p E->getSourceRange()
(clang::SourceRange) {
  B = (ID = 99)
  E = (ID = 99)
}
(lldb) p A->getSourceRange()
(clang::SourceRange) {
  B = (ID = 99)
  E = (ID = 99)
}
```
Adding a special case for `UserDefinedLiteral` doesn't seem like the right thing to do. Trying to wrap my head around what clang-tidy is doing here

https://github.com/llvm/llvm-project/pull/122265