[Lldb-commits] [lldb] [lldb] Handle a byte size of zero in CompilerType::GetValueAsScalar (PR #123107)

Jacob Lalonde via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 15 13:43:18 PST 2025


================
@@ -1105,7 +1105,7 @@ bool CompilerType::GetValueAsScalar(const lldb_private::DataExtractor &data,
       return false;
 
     std::optional<uint64_t> byte_size = GetByteSize(exe_scope);
-    if (!byte_size)
+    if (!byte_size || *byte_size == 0)
----------------
Jlalond wrote:

Nit: I would add a comment with brief context on how this appears invalid. Otherwise LGTM

https://github.com/llvm/llvm-project/pull/123107


More information about the lldb-commits mailing list