[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

Chuanqi Xu via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 14 18:03:22 PST 2025


================
@@ -145,12 +146,18 @@ class ExternalASTSource : public RefCountedBase<ExternalASTSource> {
   /// Find all declarations with the given name in the given context,
   /// and add them to the context by calling SetExternalVisibleDeclsForName
   /// or SetNoExternalVisibleDeclsForName.
-  /// \return \c true if any declarations might have been found, \c false if
-  /// we definitely have no declarations with tbis name.
+  /// \param DC since the same namespace can appear in multiple module units.
+  /// \param Name the name of the declarations to find.
+  /// \param NamedModule find declarations visible to the given module
+  /// \c NamedModule . This may be different from owning module of \c DC since
+  /// there are declarations (e.g., namespace declaration) can appear in
+  /// multiple modules. \return \c true if any declarations might have been
+  /// found, \c false if we definitely have no declarations with tbis name.
----------------
ChuanqiXu9 wrote:

Done, thanks.

https://github.com/llvm/llvm-project/pull/122887


More information about the lldb-commits mailing list