[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

[via lldb-commits]

cor3ntin wrote:

> Ah, I think you’re confusing two functions there: `getPointeeOrArrayElementType()` is being renamed to `getPointerOrObjCPointerOrArrayElementType()`, not `getPointerOrArrayElementType()`.

Not confused. renaming `getPointeeFoo` to `getPointerBar` does not seem correct, especially as `getPointeeOrArrayElementType` does indeed return a pointee.

And my other point, is that there should not be a use case for "If T is a pointer give me the pointee, otherwise give me T" - which is why I'm suggesting functions returning a pointee should not accept a non-pointer type


https://github.com/llvm/llvm-project/pull/122938