[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

[via lldb-commits]

Sirraide wrote:

> A few comment: `getPointerLikeOrArrayElementType` is not used, and I'm rather concerned by what it does.
> Removing pointiness in only some cases seem dangerous, and not super useful...

That’s fair, I don’t think it’s crucial to add that or anything.

> Renaming `getPointeeOrArrayElementType` to `getPointerOrArrayElementType` seems wrong. However, if we put an assert in these function that the type is indeed a pointer or an array, how much code break? I suspect not much, and we could fix the caller. ie this function is too magic/does too much.

Ah, I think you’re confusing two functions there: `getPointeeOrArrayElementType()` is being renamed to `getPointerOrObjCPointerOrArrayElementType()`, not `getPointerOrArrayElementType()`.

https://github.com/llvm/llvm-project/pull/122938