[Lldb-commits] [lldb] [LLDB] Make the thread list for SBSaveCoreOptions iterable (PR #122541)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 10 15:01:28 PST 2025


================
@@ -56,8 +58,10 @@ class SaveCoreOptions {
   std::optional<lldb_private::FileSpec> m_file;
   std::optional<lldb::SaveCoreStyle> m_style;
   lldb::ProcessSP m_process_sp;
-  std::unordered_set<lldb::tid_t> m_threads_to_save;
+  std::unordered_map<lldb::tid_t, lldb::ThreadSP> m_threads_to_save;
----------------
clayborg wrote:

Not sure if we need this complexity of an unordered_map + vector. Most users will add a couple of threads, or none at all. Can we just change this to be:
```
std::vector<lldb::tid_t> m_threads_to_save;
```
The get rid of `m_thread_indexes`?

https://github.com/llvm/llvm-project/pull/122541


More information about the lldb-commits mailing list