[Lldb-commits] [lldb] [lldb][AIX] Added PlatformAIX plugin (PR #121273)

[David Spickett via lldb-commits]

https://github.com/DavidSpickett commented:

I'm not clear what you're asking for feedback on here.

Starting with a copy of the Linux platform, I understand that. However the final changes don't look that different so I assume you have:
* Copied the Linux platform.
* Updated it until it builds on AIX.
* And now want some feedback for the next part?

If so, I think the first thing to do is work out if any of these Linux constructs apply to AIX at all. For example does uname exist and work? Does the siginfo type match up (certainly the MIPS code is not needed for AIX)?

Then we'll be down to what you actually want to keep for AIX, and from there we can think about whether it's worth sharing any of it.

My guess is that a lot of this won't apply to AIX or be different enough to warrant it being its own copy of the code. For example we already have different versions of GetSigInfoType for NetBSD/FreeBSD.

https://github.com/llvm/llvm-project/pull/121273