[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

[Hu Jialun via lldb-commits]

SuibianP wrote:

The patch currently suffers from a critical issue that I cannot diagnose. Help is much appreciated.

When the debug adapter attempts to attach to the launcher,

https://github.com/llvm/llvm-project/blob/4c8c18c8c54308b945d6c78e2c71ebabf29cb554/lldb/tools/lldb-dap/lldb-dap.cpp#L2039

it blocks at

https://github.com/llvm/llvm-project/blob/4c8c18c8c54308b945d6c78e2c71ebabf29cb554/lldb/source/Plugins/Process/Windows/Common/ProcessDebugger.cpp#L580-L581

although adding the following snippet at the front of `RunInTerminalLauncherCommChannel::WaitUntilDebugAdaptorAttaches` indicates that the launcher process does get paused and never resumed.

```cpp
for (int i = 0; !::IsDebuggerPresent(); ++i)
  LLVM_LOGV(log, "Waiting to be attached... {0}", i);
LLVM_LOGV(log, "Attached");
```

https://github.com/llvm/llvm-project/pull/121269