[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)
via lldb-commits
lldb-commits at lists.llvm.org
Mon Dec 23 07:04:25 PST 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {darker}-->
:warning: Python code formatter, darker found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
darker --check --diff -r 23a239267e8a1d20ed10d3545feaf2a2bb70b085...c14a0e3f80c1cc49a6717b41c8b90e2258168399 lldb/test/API/commands/frame/var-dil/basics/GlobalVariableLookup/TestFrameVarDILGlobalVariableLookup.py lldb/test/API/commands/frame/var-dil/basics/InstanceVariables/TestFrameVarDILInstanceVariables.py lldb/test/API/commands/frame/var-dil/basics/LocalVars/TestFrameVarDILLocalVars.py
``````````
</details>
<details>
<summary>
View the diff from darker here.
</summary>
``````````diff
--- GlobalVariableLookup/TestFrameVarDILGlobalVariableLookup.py 2024-12-23 14:41:46.000000 +0000
+++ GlobalVariableLookup/TestFrameVarDILGlobalVariableLookup.py 2024-12-23 15:04:00.488079 +0000
@@ -8,10 +8,11 @@
from lldbsuite.test import lldbutil
import os
import shutil
import time
+
class TestFrameVarDILGlobalVariableLookup(TestBase):
# If your test case doesn't stress debug info, then
# set this to true. That way it won't be run once for
# each debug info format.
@@ -47,36 +48,38 @@
threads = get_threads_stopped_at_breakpoint(process, breakpoint)
self.assertEqual(
len(threads), 1, "There should be a thread stopped at our breakpoint"
)
- # The hit count for the breakpoint should be 1.
+ # The hit count for the breakpoint should be 1.
self.assertEquals(breakpoint.GetHitCount(), 1)
frame = threads[0].GetFrameAtIndex(0)
command_result = lldb.SBCommandReturnObject()
interp = self.dbg.GetCommandInterpreter()
-
- self.expect("settings set target.experimental.use-DIL true",
- substrs=[""])
+ self.expect("settings set target.experimental.use-DIL true", substrs=[""])
self.expect("frame variable 'globalVar'", substrs=["-559038737"]) # 0xDEADBEEF
self.expect("frame variable 'globalPtr'", patterns=["0x[0-9]+"])
self.expect("frame variable 'globalRef'", substrs=["-559038737"])
self.expect("frame variable '::globalPtr'", patterns=["0x[0-9]+"])
self.expect("frame variable '::globalRef'", substrs=["-559038737"])
- self.expect("frame variable 'externGlobalVar'", error=True,
- substrs=["use of undeclared identifier"]) # 0x00C0FFEE
- #substrs=["no variable named 'externGlobalVar' found in this frame"]) # 0x00C0FFEE
- self.expect("frame variable '::externGlobalVar'", error=True,
- substrs=["use of undeclared identifier"]) # ["12648430"])
- #substrs=["no variable named '::externGlobalVar' found in this frame"]) # ["12648430"])
+ self.expect(
+ "frame variable 'externGlobalVar'",
+ error=True,
+ substrs=["use of undeclared identifier"],
+ ) # 0x00C0FFEE
+ # substrs=["no variable named 'externGlobalVar' found in this frame"]) # 0x00C0FFEE
+ self.expect(
+ "frame variable '::externGlobalVar'",
+ error=True,
+ substrs=["use of undeclared identifier"],
+ ) # ["12648430"])
+ # substrs=["no variable named '::externGlobalVar' found in this frame"]) # ["12648430"])
# "use of undeclared identifier"
self.expect("frame variable 'ns::globalVar'", substrs=["13"])
- self.expect("frame variable 'ns::globalPtr'",
- patterns=["0x[0-9]+"])
+ self.expect("frame variable 'ns::globalPtr'", patterns=["0x[0-9]+"])
self.expect("frame variable 'ns::globalRef'", substrs=["13"])
self.expect("frame variable '::ns::globalVar'", substrs=["13"])
- self.expect("frame variable '::ns::globalPtr'",
- patterns=["0x[0-9]+"])
+ self.expect("frame variable '::ns::globalPtr'", patterns=["0x[0-9]+"])
--- InstanceVariables/TestFrameVarDILInstanceVariables.py 2024-12-23 14:41:46.000000 +0000
+++ InstanceVariables/TestFrameVarDILInstanceVariables.py 2024-12-23 15:04:00.509379 +0000
@@ -8,10 +8,11 @@
from lldbsuite.test import lldbutil
import os
import shutil
import time
+
class TestFrameVarDILInstanceVariables(TestBase):
# If your test case doesn't stress debug info, then
# set this to true. That way it won't be run once for
# each debug info format.
@@ -47,16 +48,15 @@
threads = get_threads_stopped_at_breakpoint(process, breakpoint)
self.assertEqual(
len(threads), 1, "There should be a thread stopped at our breakpoint"
)
- # The hit count for the breakpoint should be 1.
+ # The hit count for the breakpoint should be 1.
self.assertEquals(breakpoint.GetHitCount(), 1)
frame = threads[0].GetFrameAtIndex(0)
command_result = lldb.SBCommandReturnObject()
interp = self.dbg.GetCommandInterpreter()
- self.expect("settings set target.experimental.use-DIL true",
- substrs=[""])
+ self.expect("settings set target.experimental.use-DIL true", substrs=[""])
self.expect("frame variable 'this'", patterns=["0x[0-9]+"])
self.expect("frame variable 'c'", substrs=["(field_ = -1)"])
--- LocalVars/TestFrameVarDILLocalVars.py 2024-12-23 14:41:46.000000 +0000
+++ LocalVars/TestFrameVarDILLocalVars.py 2024-12-23 15:04:00.530222 +0000
@@ -8,10 +8,11 @@
from lldbsuite.test import lldbutil
import os
import shutil
import time
+
class TestFrameVarDILLocalVars(TestBase):
# If your test case doesn't stress debug info, then
# set this to true. That way it won't be run once for
# each debug info format.
@@ -47,19 +48,18 @@
threads = get_threads_stopped_at_breakpoint(process, breakpoint)
self.assertEqual(
len(threads), 1, "There should be a thread stopped at our breakpoint"
)
- # The hit count for the breakpoint should be 1.
+ # The hit count for the breakpoint should be 1.
self.assertEquals(breakpoint.GetHitCount(), 1)
frame = threads[0].GetFrameAtIndex(0)
command_result = lldb.SBCommandReturnObject()
interp = self.dbg.GetCommandInterpreter()
# Test 'a' is 1
- self.expect("settings set target.experimental.use-DIL true",
- substrs=[""])
+ self.expect("settings set target.experimental.use-DIL true", substrs=[""])
self.expect("frame variable a", substrs=["1"])
self.expect("frame variable b", substrs=["2"])
self.expect("frame variable c", substrs=["\\xfd"])
self.expect("frame variable s", substrs=["4"])
``````````
</details>
https://github.com/llvm/llvm-project/pull/120971
More information about the lldb-commits
mailing list