[Lldb-commits] [lldb] [lldb] Negate `is_signed` variable for argument `isUnsigned` in TypeSystemClang.cpp (PR #120794)
Michael Buch via lldb-commits
lldb-commits at lists.llvm.org
Mon Dec 23 04:46:23 PST 2024
================
@@ -313,6 +313,16 @@ TEST_F(TestTypeSystemClang, TestGetEnumIntegerTypeBasicTypes) {
}
}
+TEST_F(TestTypeSystemClang, TestEnumerationValueSign) {
+ CompilerType enum_type = m_ast->CreateEnumerationType(
+ "my_enum_signed", m_ast->GetTranslationUnitDecl(),
+ OptionalClangModuleID(), Declaration(),
+ m_ast->GetBasicType(lldb::eBasicTypeSignedChar), false);
+ auto *enum_decl = m_ast->AddEnumerationValueToEnumerationType(
+ enum_type, nullptr, "minus_one", -1, 8);
----------------
Michael137 wrote:
Nit:
```suggestion
auto *enum_decl = m_ast->AddEnumerationValueToEnumerationType(
enum_type, Declaration(), "minus_one", -1, 8);
```
https://github.com/llvm/llvm-project/pull/120794
More information about the lldb-commits
mailing list