[Lldb-commits] [lldb] ac50294 - Revert "[lldb][test] Add test-coverage for DW_AT_APPLE_objc_complete_type parsing (#120279)"

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 23 02:45:45 PST 2024


Author: Michael Buch
Date: 2024-12-23T10:43:35Z
New Revision: ac5029499561a8f76e71325ffb5c59d92ff84709

URL: https://github.com/llvm/llvm-project/commit/ac5029499561a8f76e71325ffb5c59d92ff84709
DIFF: https://github.com/llvm/llvm-project/commit/ac5029499561a8f76e71325ffb5c59d92ff84709.diff

LOG: Revert "[lldb][test] Add test-coverage for DW_AT_APPLE_objc_complete_type parsing (#120279)"

This reverts commit 000febd0290698728abd9e23da6b27969c529177.

This is failing on the macOS public buildbots. It's unclear
to me why (I can't reproduce the failure on my local M1 machine).
I suspect the test might be relying on some non-deterministic
linker properties (such as order of entries in the debug-map
or something like that). The failure is as follows:
```
CHECK-NEXT: expected string not found in input
              ^
<stdin>:25:7: note: scanning from here
 y = 2
      ^
<stdin>:27:4: note: possible intended match here
(lldb) exit
   ^

Input file: <stdin>
Check file: /Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/llvm-project/lldb/test/Shell/Expr/TestObjCHiddenIvars.test

-dump-input=help explains the following input dump.

Input was:
<<<<<<
           .
           .
           .
          20: (lldb) expression *f
          21: (Foo) $0 = {
          22:  NSObject = {
          23:  isa = Foo
          24:  }
          25:  y = 2
next:21'0           X error: no match found
          26: }
next:21'0     ~~
          27: (lldb) exit
next:21'0     ~~~~~~~~~~~~
next:21'1        ?         possible intended match
>>>>>>
```

Added: 
    

Modified: 
    

Removed: 
    lldb/test/Shell/Expr/TestObjCHiddenIvars.test


################################################################################
diff  --git a/lldb/test/Shell/Expr/TestObjCHiddenIvars.test b/lldb/test/Shell/Expr/TestObjCHiddenIvars.test
deleted file mode 100644
index 18c496e4d2d271..00000000000000
--- a/lldb/test/Shell/Expr/TestObjCHiddenIvars.test
+++ /dev/null
@@ -1,65 +0,0 @@
-# REQUIRES: system-darwin
-#
-# Tests that LLDB correctly finds the implementation
-# DIE (with a `DW_AT_APPLE_objc_complete_type`)
-# given an interface DIE (without said attribute).
-#
-# RUN: split-file %s %t
-# RUN: %clangxx_host %t/lib.m  -c -g -o %t/lib.o
-# RUN: %clangxx_host %t/main.m -c -g -o %t/main.o
-# RUN: %clangxx_host %t/main.o %t/lib.o -o %t/a.out -framework Foundation
-#
-# RUN: %lldb %t/a.out \
-# RUN:       -o "breakpoint set -p 'return' -X main" \
-# RUN:       -o run \
-# RUN:       -o "expression *f" \
-# RUN:       -o exit | FileCheck %s
-
-# CHECK:      (lldb) expression *f
-# CHECK:      (Foo) ${{[0-9]+}} = {
-# CHECK:         y = 2 
-# CHECK-NEXT:    i = 1 
-
-#--- main.m
-#import <Foundation/Foundation.h>
-#import "lib.h"
-
-extern Foo * func();
-
-int main() {
-    Foo * f = func();
-    return 0;
-}
-
-#--- lib.m
-#import <Foundation/Foundation.h>
-#import "lib.h"
-
- at implementation Foo {
-int i;
-}
-
-- (id)init {
-  self->i = 1;
-  self->y = 2;
-
-  return self;
-}
- at end
-
-Foo * func() {
-  return [[Foo alloc] init];
-}
-
-#--- lib.h
-#ifndef LIB_H_IN
-#define LIB_H_IN
-
-#import <Foundation/Foundation.h>
-
- at interface Foo : NSObject {
-int y;
-}
- at end
-
-#endif  // _H_IN


        


More information about the lldb-commits mailing list