[Lldb-commits] [lldb] [lldb][AIX] Introducing _ALL_SOURCE macro into driver CMakeLists (PR #120607)

[Dhruv Srivastava via lldb-commits]

================
@@ -11,6 +11,11 @@ if(APPLE)
   set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,-sectcreate,__TEXT,__info_plist,${CMAKE_CURRENT_BINARY_DIR}/lldb-Info.plist")
 endif()
 
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")                               
+  remove_definitions("-D_XOPEN_SOURCE=700")                                    
----------------
DhruvSrivastavaX wrote:

Okay, It was added by another team in IBM but I think the intention to add this way to only utilise the relevant posix standard definitions and avoid any extra un-needed definitions. But then again, some definitions being used in LLDB code, do not come under the `_X_OPEN_SOURCE` for AIX, in which case we need to use `_ALL_SOURCE` instead. But yes, I can check if only having add_definitions does not cause any compilation conflicts and update accordingly.

https://github.com/llvm/llvm-project/pull/120607