[Lldb-commits] [lldb] Refactor `ThreadList::WillResume()` to prepare to support reverse execution (PR #120817)
via lldb-commits
lldb-commits at lists.llvm.org
Fri Dec 20 18:48:08 PST 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 904849f2973eb8ab517f8a805cf8a747924220ef 68b8c34095430e65ce9d69e8fb4c7e70132b8f0c --extensions cpp,h -- lldb/include/lldb/Target/Thread.h lldb/source/Target/Thread.cpp lldb/source/Target/ThreadList.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/lldb/source/Target/ThreadList.cpp b/lldb/source/Target/ThreadList.cpp
index 2e62e46f88..b800d6e4ae 100644
--- a/lldb/source/Target/ThreadList.cpp
+++ b/lldb/source/Target/ThreadList.cpp
@@ -546,7 +546,7 @@ bool ThreadList::WillResume() {
if (thread_sp == GetSelectedThread())
thread_to_run = thread_sp;
-
+
if (thread_sp->ShouldRunBeforePublicStop()) {
// This takes precedence, so if we find one of these, service it:
thread_to_run = thread_sp;
@@ -573,9 +573,9 @@ bool ThreadList::WillResume() {
bool wants_solo_run = run_me_only_list.GetSize(false) > 0;
for (pos = m_threads.begin(); pos != end; ++pos) {
ThreadSP thread_sp(*pos);
- // See if any thread wants to run stopping others. If it does, then we won't
- // setup the other threads for resume, since they aren't going to get a
- // chance to run. This is necessary because the SetupForResume might add
+ // See if any thread wants to run stopping others. If it does, then we
+ // won't setup the other threads for resume, since they aren't going to get
+ // a chance to run. This is necessary because the SetupForResume might add
// "StopOthers" plans which would then get to be part of the who-gets-to-run
// negotiation, but they're coming in after the fact, and the threads that
// are already set up should take priority.
``````````
</details>
https://github.com/llvm/llvm-project/pull/120817
More information about the lldb-commits
mailing list