[Lldb-commits] [lldb] [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (PR #120457)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 20 02:37:51 PST 2024


================
@@ -173,6 +178,63 @@ ExceptionBreakpoint *DAP::GetExceptionBreakpoint(const lldb::break_id_t bp_id) {
   return nullptr;
 }
 
+llvm::Error DAP::ConfigureIO(std::optional<std::FILE *> overrideOut,
----------------
labath wrote:

optional<T*> is overkill in most of the cases (and confusing in the rest). Can you use a null pointer to denote an empty value?

https://github.com/llvm/llvm-project/pull/120457


More information about the lldb-commits mailing list