[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Remove unused parameter to CompleteRecordType (PR #120456)

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Wed Dec 18 09:13:29 PST 2024


https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/120456

Became unused since the recent
https://github.com/llvm/llvm-project/pull/110648

>From e9a8d02777b3e618a7c55f6b13d8b2ce2a73162c Mon Sep 17 00:00:00 2001
From: Michael Buch <michaelbuch12 at gmail.com>
Date: Wed, 18 Dec 2024 17:10:42 +0000
Subject: [PATCH] [lldb][DWARFASTParserClang][NFC] Remove unused parameter to
 CompleteRecordType

Became unused since the recent
https://github.com/llvm/llvm-project/pull/110648
---
 lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp | 3 +--
 lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h   | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
index 37c1132c1c9f9a..7c57484f56a7d2 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
@@ -2066,7 +2066,6 @@ bool DWARFASTParserClang::ParseTemplateParameterInfos(
 }
 
 bool DWARFASTParserClang::CompleteRecordType(const DWARFDIE &die,
-                                             lldb_private::Type *type,
                                              const CompilerType &clang_type) {
   const dw_tag_t tag = die.Tag();
   SymbolFileDWARF *dwarf = die.GetDWARF();
@@ -2203,7 +2202,7 @@ bool DWARFASTParserClang::CompleteTypeFromDWARF(
   case DW_TAG_structure_type:
   case DW_TAG_union_type:
   case DW_TAG_class_type:
-    CompleteRecordType(die, type, clang_type);
+    CompleteRecordType(die, clang_type);
     break;
   case DW_TAG_enumeration_type:
     CompleteEnumType(die, type, clang_type);
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h
index 6c3aac6d452e49..55f8e38d7486d6 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h
@@ -421,7 +421,6 @@ class DWARFASTParserClang : public lldb_private::plugin::dwarf::DWARFASTParser {
       const lldb_private::CompilerType &class_clang_type);
 
   bool CompleteRecordType(const lldb_private::plugin::dwarf::DWARFDIE &die,
-                          lldb_private::Type *type,
                           const lldb_private::CompilerType &clang_type);
   bool CompleteEnumType(const lldb_private::plugin::dwarf::DWARFDIE &die,
                         lldb_private::Type *type,



More information about the lldb-commits mailing list