[Lldb-commits] [lldb] [lldb][AIX] Adding AIX version of ptrace64 (PR #120390)
David Spickett via lldb-commits
lldb-commits at lists.llvm.org
Wed Dec 18 02:15:23 PST 2024
================
@@ -193,8 +192,13 @@ struct ForkLaunchInfo {
}
// Start tracing this child that is about to exec.
+#if !defined(_AIX)
----------------
DavidSpickett wrote:
Generally I would prefer positive conditions as the first part of an if. So here it would be if AIX use ptrace64, else use ptrace.
Also I would keep the body of the if common:
```
#ifdef AIX
if (ptrace64(...))
#else
if (ptrace(...))
#endif
ExitWithError(...);
```
https://github.com/llvm/llvm-project/pull/120390
More information about the lldb-commits
mailing list