[Lldb-commits] [lldb] [WIP][lldb][DWARFASTParserClang] Eagerly search definitions for Objective-C classes (PR #119860)

[Zequan Wu via lldb-commits]

ZequanWu wrote:

> I think the way it's currently written doesn't handle the case where we call ParseStructureLikeDIE with a forward declaration, and then later on with a definition DIE. For C++ structures we handle that by updating the UniqueTypeMap with the definition DIE, etc. We'll probably have to do what we do for enums and also put the definition DIE into the DIEToType map.

In `UniqueTypeMap`, C++ is only special in that the unique name is constructed by walking all the way up in the DIE tree to get its fully qualified name. If we can do something similar when constructing the unique names for objc/objc++, that map should be reusable. 

Actually, there's already a block to eagerly find the complete type when `!is_complete_objc_class` for objc/objc++: https://github.com/llvm/llvm-project/blob/c9a5a6d18bd71b203798b9188f565bdf173ad91b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp#L1713-L1715. How is it different from the change in this PR? Is `is_complete_objc_class` the same as `!is_forward_declaration`?

https://github.com/llvm/llvm-project/pull/119860