[Lldb-commits] [lldb] [LLDB] Add external progress bit category (PR #120171)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 17 08:28:30 PST 2024


================
@@ -106,9 +107,15 @@ void Progress::ReportProgress() {
   if (completed < m_prev_completed)
     return; // An overflow in the m_completed counter. Just ignore these events.
 
+  // Change the category bit if we're an internal or external progress.
+  uint32_t progress_category_bit =
+      m_origin == ProgressOrigin::eExternal
+          ? lldb::eBroadcastBitExternalProgressCategory
+          : lldb::eBroadcastBitProgressCategory;
----------------
JDevlieghere wrote:

This is wrong, it will report all progress events as aggregated by category. You'll need to check both `eBroadcastBitProgress` and `eBroadcastBitProgressCategory` and pick the right external variant. 

https://github.com/llvm/llvm-project/pull/120171


More information about the lldb-commits mailing list