[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 17 02:00:05 PST 2024


================
@@ -115,14 +115,18 @@ class ThreadList : public ThreadCollection {
   /// If a thread can "resume" without having to resume the target, it
   /// will return false for WillResume, and then the process will not be
   /// restarted.
+  /// Sets *direction to the run direction of the thread(s) that will
+  /// be resumed. If threads that we want to run disagree about the
+  /// direction, we execute forwards and pop any of the thread plans
+  /// that requested reverse execution.
   ///
   /// \return
   ///    \b true instructs the process to resume normally,
   ///    \b false means start & stopped events will be generated, but
   ///    the process will not actually run.  The thread must then return
   ///    the correct StopInfo when asked.
   ///
-  bool WillResume();
+  bool WillResume(lldb::RunDirection *direction);
----------------
labath wrote:

If this is always going to be non-null (which I think is the case), make it a reference -- or maybe change the return type (`optional<RunDirection>` ?)

https://github.com/llvm/llvm-project/pull/112079


More information about the lldb-commits mailing list