[Lldb-commits] [lldb] 11d2911 - [lldb] Fix warnings

[Kazu Hirata via lldb-commits]

Author: Kazu Hirata
Date: 2024-12-16T09:34:08-08:00
New Revision: 11d2911ef117aef2afb136339f0c24f8eee10c32

URL: https://github.com/llvm/llvm-project/commit/11d2911ef117aef2afb136339f0c24f8eee10c32
DIFF: https://github.com/llvm/llvm-project/commit/11d2911ef117aef2afb136339f0c24f8eee10c32.diff

LOG: [lldb] Fix warnings

This patch fixes:

  third-party/unittest/googletest/include/gtest/gtest.h:1379:11:
  error: comparison of integers of different signs: 'const unsigned
  long' and 'const int' [-Werror,-Wsign-compare]

Added: 
    

Modified: 
    lldb/unittests/Core/ProgressReportTest.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/Core/ProgressReportTest.cpp b/lldb/unittests/Core/ProgressReportTest.cpp
index d03b3bc39f8e07..20324e92523874 100644
--- a/lldb/unittests/Core/ProgressReportTest.cpp
+++ b/lldb/unittests/Core/ProgressReportTest.cpp
@@ -225,14 +225,14 @@ TEST_F(ProgressReportTest, TestFiniteOverflow) {
   ASSERT_TRUE(listener_sp->GetEvent(event_sp, TIMEOUT));
   data = ProgressEventData::GetEventDataFromEvent(event_sp.get());
   EXPECT_TRUE(data->IsFinite());
-  EXPECT_EQ(data->GetCompleted(), 0);
-  EXPECT_EQ(data->GetTotal(), 10);
+  EXPECT_EQ(data->GetCompleted(), 0U);
+  EXPECT_EQ(data->GetTotal(), 10U);
 
   ASSERT_TRUE(listener_sp->GetEvent(event_sp, TIMEOUT));
   data = ProgressEventData::GetEventDataFromEvent(event_sp.get());
   EXPECT_TRUE(data->IsFinite());
-  EXPECT_EQ(data->GetCompleted(), 10);
-  EXPECT_EQ(data->GetTotal(), 10);
+  EXPECT_EQ(data->GetCompleted(), 10U);
+  EXPECT_EQ(data->GetTotal(), 10U);
 
   ASSERT_FALSE(listener_sp->GetEvent(event_sp, TIMEOUT));
 }
@@ -254,7 +254,7 @@ TEST_F(ProgressReportTest, TestNonDeterministicOverflow) {
   ASSERT_TRUE(listener_sp->GetEvent(event_sp, TIMEOUT));
   data = ProgressEventData::GetEventDataFromEvent(event_sp.get());
   EXPECT_FALSE(data->IsFinite());
-  EXPECT_EQ(data->GetCompleted(), 0);
+  EXPECT_EQ(data->GetCompleted(), 0U);
   EXPECT_EQ(data->GetTotal(), Progress::kNonDeterministicTotal);
 
   ASSERT_TRUE(listener_sp->GetEvent(event_sp, TIMEOUT));
@@ -295,20 +295,20 @@ TEST_F(ProgressReportTest, TestMinimumReportTime) {
   ASSERT_TRUE(listener_sp->GetEvent(event_sp, TIMEOUT));
   data = ProgressEventData::GetEventDataFromEvent(event_sp.get());
   EXPECT_TRUE(data->IsFinite());
-  EXPECT_EQ(data->GetCompleted(), 0);
-  EXPECT_EQ(data->GetTotal(), 20);
+  EXPECT_EQ(data->GetCompleted(), 0U);
+  EXPECT_EQ(data->GetTotal(), 20U);
 
   ASSERT_TRUE(listener_sp->GetEvent(event_sp, TIMEOUT));
   data = ProgressEventData::GetEventDataFromEvent(event_sp.get());
   EXPECT_TRUE(data->IsFinite());
-  EXPECT_EQ(data->GetCompleted(), 11);
-  EXPECT_EQ(data->GetTotal(), 20);
+  EXPECT_EQ(data->GetCompleted(), 11U);
+  EXPECT_EQ(data->GetTotal(), 20U);
 
   ASSERT_TRUE(listener_sp->GetEvent(event_sp, TIMEOUT));
   data = ProgressEventData::GetEventDataFromEvent(event_sp.get());
   EXPECT_TRUE(data->IsFinite());
-  EXPECT_EQ(data->GetCompleted(), 20);
-  EXPECT_EQ(data->GetTotal(), 20);
+  EXPECT_EQ(data->GetCompleted(), 20U);
+  EXPECT_EQ(data->GetTotal(), 20U);
 
   ASSERT_FALSE(listener_sp->GetEvent(event_sp, TIMEOUT));
 }