[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

Robert O'Callahan via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 13 19:50:57 PST 2024


================
@@ -3265,18 +3275,25 @@ Status Process::PrivateResume() {
     // (suspended/running/stepping). Threads should also check their resume
     // signal in lldb::Thread::GetResumeSignal() to see if they are supposed to
     // start back up with a signal.
-    if (m_thread_list.WillResume()) {
+    RunDirection direction;
----------------
rocallahan wrote:

OK, let me gently disagree about this :-). In terms of code complexity, adding a call to `Process::CanReverseContinue()` is a tiny bit more complex than not having it. In terms of performance, I don't think it's important to make it a tiny bit faster to report that reverse-continue is not supported. Is there some other consideration?

https://github.com/llvm/llvm-project/pull/112079


More information about the lldb-commits mailing list