[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

Robert O'Callahan via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 13 19:34:07 PST 2024


================
@@ -236,11 +236,18 @@ ProcessWindows::DoAttachToProcessWithID(lldb::pid_t pid,
   return error;
 }
 
-Status ProcessWindows::DoResume() {
+Status ProcessWindows::DoResume(RunDirection direction) {
   Log *log = GetLog(WindowsLog::Process);
   llvm::sys::ScopedLock lock(m_mutex);
   Status error;
 
+  if (direction == RunDirection::eRunReverse) {
----------------
rocallahan wrote:

Yes, but ... if we do that, `DoResume()` still needs to report an error if `direction` is not supported, right? And if we have to report an error anyway, then I think `Process::SupportsReverseContinue()` is superfluous.

https://github.com/llvm/llvm-project/pull/112079


More information about the lldb-commits mailing list