[Lldb-commits] [lldb] [lldb] Require gmake on FreeBSD and NetBSD (PR #119573)

[David Spickett via lldb-commits]

DavidSpickett wrote:

> So, now the problem is that FreeBSD has both, make and gmake, and when we pick up make, the tests fail right? Wouldn't it be sufficient to change the order?

It will fix the build on FreeBSD where you have `pkg install gmake`, but on a system without it, it will find make and all the tests will fail to build.

Though.

It is a warning when we don't find a make at all. So you could argue that we should accept `make` on FreeBSD so you can build out of the box, and if you run the tests that's your problem. But in this case - it was my problem!

So yes maybe gmake only on those systems is a bit harsh.

> Not sure which platforms actually have it, but it feels incorrect.

I'm assuming anything that has "gmake" it'll be a GNU compatible make, or at least more compatible than "make.

I could just switch the order. Prefer gmake on BSDs, prefer make everywhere else. Which is effectively what was happening before your patch, and it means you can still build on BSD without having to install gmake. At the cost of weird errors maybe.

I'll add a warning on BSD that we've found `make` but it likely won't compile tests properly.

https://github.com/llvm/llvm-project/pull/119573