[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 10 17:39:51 PST 2024


================
@@ -617,25 +617,26 @@ void Thread::WillStop() {
   current_plan->WillStop();
 }
 
-void Thread::SetupForResume() {
+bool Thread::StepOverBreakpointIfNeeded(RunDirection direction) {
----------------
jimingham wrote:

That name no longer describes what this function does. It checks more things than just whether we need to step over a breakpoint, like whether this thread is suspended so we don't need to do anything, or if this is going to be a virtual step so we don't need to resume either.
SetUpForResume is a little too vague, but it's worse to say the function only does certain things when that's not in fact true.

https://github.com/llvm/llvm-project/pull/112079


More information about the lldb-commits mailing list