[Lldb-commits] [lldb] Convert the StackFrameList mutex to a shared mutex. (PR #117252)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 10 07:54:30 PST 2024


================
@@ -594,7 +643,7 @@ StackFrameSP StackFrameList::GetFrameAtIndex(uint32_t idx) {
   // GetFramesUpTo will fill m_frames with as many frames as you asked for, if
   // there are that many.  If there weren't then you asked for too many frames.
   // GetFramesUpTo returns true if interrupted:
-  if (GetFramesUpTo(idx)) {
+  if (GetFramesUpTo(idx, AllowInterruption, guard)) {
     Log *log = GetLog(LLDBLog::Thread);
     LLDB_LOG(log, "GetFrameAtIndex was interrupted");
     return {};
----------------
labath wrote:

Sounds good. Thanks.

That said, I think the code below still needs a read lock as it's accessing m_frames. I think that might be avoidable if `GetFramesUpTo` returned the frame it was asked for (see other suggestions).

https://github.com/llvm/llvm-project/pull/117252


More information about the lldb-commits mailing list