[Lldb-commits] [lldb] [lldb] do not show misleading error when there is no frame (PR #119103)

[Jonas Devlieghere via lldb-commits]

================
@@ -1012,33 +1006,26 @@ bool SBFrame::GetDescription(SBStream &description) {
 SBValue SBFrame::EvaluateExpression(const char *expr) {
   LLDB_INSTRUMENT_VA(this, expr);
 
-  SBValue result;
   std::unique_lock<std::recursive_mutex> lock;
   ExecutionContext exe_ctx(m_opaque_sp.get(), lock);
 
   StackFrame *frame = exe_ctx.GetFramePtr();
   Target *target = exe_ctx.GetTargetPtr();
+  SBExpressionOptions options;
   if (frame && target) {
----------------
JDevlieghere wrote:

Should this still check the target? Maybe something like:

```
if(frame) {
  if (Target* target = frame->CalculateTarget()) 
    lldb::DynamicValueType fetch_dynamic_value = target->GetPreferDynamicValue();
    options.SetFetchDynamicValue(fetch_dynamic_value);
  }
}
```

https://github.com/llvm/llvm-project/pull/119103