[Lldb-commits] [lldb] [lldb] do not show misleading error when there is no frame (PR #119103)

via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 9 09:49:32 PST 2024


oltolm wrote:

> Thanks for not ignoring the formatter - but - please remove the formatting changes in this case because it's obscuring the actual change. When changing existing code like this, we often ignore the formatter for this reason.

Done.
 
> Also, I'm not sure this is any better. I guess that `br list` is evaluated as an expression by default and that `'br list` is the escape character to say "execute this as a command".
> 
> So if the target were running, `expr br list` would indeed fail with `can't evaluate expressions when the process is running.`. As it is - running. Are you saying that it does this even when stopped?

Yes, this message appears even when stopped. I know that "sbframe object is not valid." is not helpful, but at least it is not misleading. I could improve it in this PR if you have any suggestions or leave it for another PR.

https://github.com/llvm/llvm-project/pull/119103


More information about the lldb-commits mailing list