[Lldb-commits] [lldb] [lldb][test] Link certain libc++ tests with the whole library (PR #118986)

[Pavel Labath via lldb-commits]

https://github.com/labath commented:

It's definitely better, but I'm still not particularly thrilled with this approach. IIUC, you made this work by changing the buildbot configuration, which is fine if you control all the buildbots that build this way, but it's definitely not ideal. The linker flags are skipped on darwin because their linker doesn't understand them, which works because darwin currently always builds libc++ dynamically, but if that changed, we'd need a darwin-specific version of this. The same goes for windows, which currently works only because we're always using lld.

OTOH, pulling in a symbol by referencing it from a C++ file should work under pretty much any configuration.

https://github.com/llvm/llvm-project/pull/118986