[Lldb-commits] [lldb] [LLDB][Process/Utility] Introduce NativeRegisterContextDBReg class (PR #118043)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 6 04:19:30 PST 2024


DavidSpickett wrote:

The test failures were caused by:
```
virtual bool ValidateWatchpoint(size_t size, lldb::addr_t &addr) = 0;
```
Which is actually trying to change size for AArch64, but it's passed by copy so it wasn't being updated in the caller. See my comments on those lines.

With that fixed, the test suite passes.

If you address that, I'll test this again. If it's all working then you can address @SixWeining 's style suggestions from the original PR, and I'll have a few of my own.

https://github.com/llvm/llvm-project/pull/118043


More information about the lldb-commits mailing list