[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

John Harrison via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 3 14:44:21 PST 2024


================
@@ -8,15 +11,7 @@ import { LLDBDapOptions } from "./types";
 export class LLDBDapDescriptorFactory
   implements vscode.DebugAdapterDescriptorFactory
 {
-  private lldbDapOptions: LLDBDapOptions;
-
-  constructor(lldbDapOptions: LLDBDapOptions) {
-    this.lldbDapOptions = lldbDapOptions;
-  }
-
-  static async isValidDebugAdapterPath(
-    pathUri: vscode.Uri,
-  ): Promise<Boolean> {
+  static async isValidFile(pathUri: vscode.Uri): Promise<Boolean> {
----------------
ashgti wrote:

Should this just be a function outside of the class?

https://github.com/llvm/llvm-project/pull/118547


More information about the lldb-commits mailing list