[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 3 09:42:01 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 071da9261b7e94c2d2d4e9d3d4eba1f29115e8ae 0a512cb8e1883a37ef0dfe389de7c59cb1e51c03 --extensions h,cpp -- lldb/include/lldb/Host/Socket.h lldb/include/lldb/Host/common/TCPSocket.h lldb/include/lldb/Host/posix/DomainSocket.h lldb/source/Host/common/TCPSocket.cpp lldb/source/Host/posix/DomainSocket.cpp lldb/unittests/Host/SocketTest.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/include/lldb/Host/Socket.h b/lldb/include/lldb/Host/Socket.h
index faa27dca50..4585eac12e 100644
--- a/lldb/include/lldb/Host/Socket.h
+++ b/lldb/include/lldb/Host/Socket.h
@@ -153,7 +153,9 @@ public:
   virtual std::string GetRemoteConnectionURI() const { return ""; };
 
   // If the Socket is listening then return the URI for clients to connect.
-  virtual std::vector<std::string> GetListeningConnectionURI() const { return {}; }
+  virtual std::vector<std::string> GetListeningConnectionURI() const {
+    return {};
+  }
 
 protected:
   Socket(SocketProtocol protocol, bool should_close);
diff --git a/lldb/unittests/Host/SocketTest.cpp b/lldb/unittests/Host/SocketTest.cpp
index 75e279fa32..712acfcfdc 100644
--- a/lldb/unittests/Host/SocketTest.cpp
+++ b/lldb/unittests/Host/SocketTest.cpp
@@ -299,7 +299,8 @@ TEST_P(SocketTest, UDPGetConnectURI) {
 #if LLDB_ENABLE_POSIX
 TEST_P(SocketTest, DomainGetConnectURI) {
   llvm::SmallString<64> domain_path;
-  std::error_code EC = llvm::sys::fs::createUniqueDirectory("DomainListenConnectAccept", domain_path);
+  std::error_code EC = llvm::sys::fs::createUniqueDirectory(
+      "DomainListenConnectAccept", domain_path);
   ASSERT_FALSE(EC);
   llvm::sys::path::append(domain_path, "test");
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/118330


More information about the lldb-commits mailing list