[Lldb-commits] [lldb] [lldb] Fix "exact match" debug_names type queries (PR #118465)

Michael Buch via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 3 03:13:20 PST 2024


================
@@ -527,7 +527,7 @@ void DebugNamesDWARFIndex::GetTypesWithQuery(
   ConstString name = query.GetTypeBasename();
   std::vector<lldb_private::CompilerContext> query_context =
       query.GetContextRef();
-  if (query_context.size() <= 1)
+  if (query_context.size() <= 1 && !query.GetExactMatch())
----------------
Michael137 wrote:

Nit (possibly for a separate PR if you prefer): could we change this to `== 1`? Would we ever get an empty context here? That feels like an invalid query. `GetTypes` already unconditionally accesses the zeroth element, which makes me think we're missing a check/assert for an empty context somewhere

https://github.com/llvm/llvm-project/pull/118465


More information about the lldb-commits mailing list