[Lldb-commits] [lldb] Add 'FindFirstSymbolWithNameAndType()' to ModuleList. (PR #117777)

[Pavel Labath via lldb-commits]

labath wrote:

> > I'm only using it in an internal branch
> 
> Not sure what the protocol is for this (CC @JDevlieghere @labath). At the very least we should have some coverage for it in the test-suite. There's precedent for this, e.g., APIs that only get exercised on the Swift branch, but at least those are on a public fork and tested on public build-bots.

I don't really know how to answer this generally, but I'm not particularly concerned about this change, since its just a wrapper over another API and it fits in with the general design of our other APIs. A test would definitely be nice, but I don't know how easy it is to set up (given its an internal API, it would need to go through a unit test, etc.).

I think the easiest way to motivate this change and satisfy the testing requirement would be to find upstream use case(s) for this function -- and it looks like this is a perfect candidate for the simplification of MemoryHistoryAsan::CreateInstance.


https://github.com/llvm/llvm-project/pull/117777