[Lldb-commits] [lldb] build: enable CONFIG mode search for LibXml2 for LLDB (PR #117615)

[Saleem Abdulrasool via lldb-commits]

================
@@ -57,7 +57,17 @@ add_optional_dependency(LLDB_ENABLE_CURSES "Enable curses support in LLDB" Curse
 add_optional_dependency(LLDB_ENABLE_LZMA "Enable LZMA compression support in LLDB" LibLZMA LIBLZMA_FOUND)
 add_optional_dependency(LLDB_ENABLE_LUA "Enable Lua scripting support in LLDB" LuaAndSwig LUAANDSWIG_FOUND)
 add_optional_dependency(LLDB_ENABLE_PYTHON "Enable Python scripting support in LLDB" PythonAndSwig PYTHONANDSWIG_FOUND)
-add_optional_dependency(LLDB_ENABLE_LIBXML2 "Enable Libxml 2 support in LLDB" LibXml2 LIBXML2_FOUND VERSION 2.8)
+# LibXml2 is required if LLDB_ENABLE_LIBXML2 is ON or AUTO. The LibXml2 package
+# search is not setup properly to support the CONFIG mode search. Furthermore,
----------------
compnerd wrote:

I believe, the issue is on the CMake side :( The documentation states that a `find_package` is supposed to search for the `CONFIG` and `MODULE` mode. This is now what I'm seeing with libxml2. It only searches in `MODULE` mode.

The CONFIG mode works completely once invoked. The problem is I'm worried that not everyone is building libxml2 with CMake and the `CONFIG` mode works only for those that are using CMake.

I can rewrite the comment.

https://github.com/llvm/llvm-project/pull/117615