[Lldb-commits] [lldb] [LLDB][ThreadELFCore] Set all the properties of ELFLinuxSigInfo to a non build dependent size (PR #117604)

Tulio Magno Quites Machado Filho via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 26 04:12:54 PST 2024


https://github.com/tuliom approved this pull request.

The build succeeded!

The source comment at line 82 caught my attention, though.
It may imply that data layout is important in this struct, i.e. it should match `siginfo_t` returned by the OS. But this change is not guaranteeing that.

Actually, the order of the first 3 integers do change on different systems.

With that said, this LGTM considering that data layout doesn't need to match the OS' `siginfo_t`.

https://github.com/llvm/llvm-project/pull/117604


More information about the lldb-commits mailing list