[Lldb-commits] [lldb] [llvm] [DWARF] Fix DWARTTypePrinter unable to print qualified name for DW_TAG_typedef DIE (PR #117239)

Zequan Wu via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 22 11:29:56 PST 2024


ZequanWu wrote:

> Where those names go from "const string" to "const std::__1::string" (and from "string" to "std::__1::string")? or something like that.

Yes. In some cases, it's getting super verbose, e.g: `std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::value_type`.

> Probably the most common way to test this would be to add something in llvm/test/DebugInfo/X86/dwarfdump-*.ll
> 
> Oh, this test might be where we test most of this in the past: llvm/test/tools/llvm-dwarfdump/X86/prettyprint_types.s

Because DWARTTypePrinter is used by both llvm-dwarfump and lldb (after a reland), how about just test DWARTTypePrinter in `llvm/unittests/DebugInfo/DWARF/DWARFDieTest.cpp` as an unit test? 

https://github.com/llvm/llvm-project/pull/117239


More information about the lldb-commits mailing list