[Lldb-commits] [lldb] Reapply "[lldb] Convert file address to load address when reading memory for DW_OP_piece" (PR #117168)

[Leandro Lupori via lldb-commits]

luporl wrote:

It looks like this broke lldb-aarch64-windows: https://lab.llvm.org/buildbot/#/builders/141/builds/4061

```
FAIL: lldb-shell :: SymbolFile/DWARF/DW_OP_piece-O3.c (1581 of 2048)
******************** TEST 'lldb-shell :: SymbolFile/DWARF/DW_OP_piece-O3.c' FAILED ********************
Exit Code: 1
Command Output (stdout):
--
# RUN: at line 8
c:\users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe --target=specify-a-target-or-use-a-_host-substitution --target=aarch64-pc-windows-msvc -fmodules-cache-path=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-clang\lldb-shell -O3 -gdwarf C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\Shell\SymbolFile\DWARF\DW_OP_piece-O3.c -o C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\tools\lldb\test\Shell\SymbolFile\DWARF\Output\DW_OP_piece-O3.c.tmp
# executed command: 'c:\users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe' --target=specify-a-target-or-use-a-_host-substitution --target=aarch64-pc-windows-msvc '-fmodules-cache-path=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-clang\lldb-shell' -O3 -gdwarf 'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\Shell\SymbolFile\DWARF\DW_OP_piece-O3.c' -o 'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\tools\lldb\test\Shell\SymbolFile\DWARF\Output\DW_OP_piece-O3.c.tmp'
# .---command stderr------------
# | clang: warning: argument unused during compilation: '-fmodules-cache-path=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-clang\lldb-shell' [-Wunused-command-line-argument]
# `-----------------------------
# RUN: at line 9
c:\users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\lldb.exe --no-lldbinit -S C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/tools/lldb\test\Shell\lit-lldb-init-quiet C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\tools\lldb\test\Shell\SymbolFile\DWARF\Output\DW_OP_piece-O3.c.tmp    -o "b 25"    -o "r"    -o "p/x array[2]"    -b | c:\users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\filecheck.exe C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\Shell\SymbolFile\DWARF\DW_OP_piece-O3.c
# executed command: 'c:\users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\lldb.exe' --no-lldbinit -S 'C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/tools/lldb\test\Shell\lit-lldb-init-quiet' 'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\tools\lldb\test\Shell\SymbolFile\DWARF\Output\DW_OP_piece-O3.c.tmp' -o 'b 25' -o r -o 'p/x array[2]' -b
# .---command stderr------------
# | error: No selected frame to use to find the default file.
# | error: No file supplied and no default file available.
# `-----------------------------
# error: command failed with exit status: 1
# executed command: 'c:\users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\filecheck.exe' 'C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\Shell\SymbolFile\DWARF\DW_OP_piece-O3.c'
# .---command stderr------------
# | C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\Shell\SymbolFile\DWARF\DW_OP_piece-O3.c:15:11: error: CHECK: expected string not found in input
# | // CHECK: (lldb) p/x array[2]
# |           ^
# | <stdin>:1:1: note: scanning from here
# | (lldb) command source -s 0 'C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/tools/lldb\test\Shell\lit-lldb-init-quiet'
# | ^
# | <stdin>:6:1: note: possible intended match here
# | (lldb) b 25
...
```

Can you please take a look?

https://github.com/llvm/llvm-project/pull/117168